Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RateRuleConverter crashes on unsupported math #394

Merged
merged 1 commit into from
Aug 28, 2024
Merged

RateRuleConverter crashes on unsupported math #394

merged 1 commit into from
Aug 28, 2024

Conversation

fbergmann
Copy link
Member

Description

raterule converter isPositive would crash on unsupported math (like sin / cos).

Motivation and Context

fixes a segfault

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann requested a review from skeating August 27, 2024 16:51
@skeating skeating merged commit 40a5856 into development Aug 28, 2024
35 checks passed
@skeating skeating deleted the raterule-converter-crash branch August 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeating skeating skeating approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbergmann @skeating