Issue 385: flexibility with running strict unit validation #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the strict unit validator to the options, so it can be run using checkConsistency. Additionally it adds an override flag to checkConsistencyWithStrictUnits, so that callers can decide as to the status of unit issues.
The PR is written so that the behavior with it is the same as before:
StrictUnitsCheckON
withsetConsistencyChecks
for it to be run withcheckConsistency
Motivation and Context
fixes #385
Types of changes
Checklist:
Testing