Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect ZLIB using find module #382

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Detect ZLIB using find module #382

merged 1 commit into from
Aug 19, 2024

Conversation

fbergmann
Copy link
Member

Description

This change detects ZLIB using the included Find Module.

Motivation and Context

This solves the problem, that currently conda packages dont build because zlib cannot be found, even though it is compiled and present from the dependencies package.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically
    while this is not automatically tested, you can easily see that with this change the variable is picked up from the defined LIBSBML_DEPENDENCY_DIR where before it would have picked up from the system (or not at all)

@fbergmann fbergmann requested a review from skeating August 9, 2024 11:37
@fbergmann fbergmann merged commit 1d87f52 into development Aug 19, 2024
35 checks passed
@fbergmann fbergmann deleted the zlib-patch branch August 19, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants