Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added MATLAB binding for the new FBC variables #351

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Added MATLAB binding for the new FBC variables #351

merged 1 commit into from
Sep 21, 2023

Conversation

skeating
Copy link
Member

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@skeating skeating requested a review from fbergmann September 21, 2023 10:13
fbergmann
fbergmann approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failures are due to SWIG not installing on testrunners, but that has no influence on the PR.

so thank you for getting this in!

@fbergmann fbergmann merged commit fee56c9 into development Sep 21, 2023
33 of 35 checks passed
@fbergmann fbergmann deleted the sk-finalv3 branch September 21, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbergmann fbergmann fbergmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skeating @fbergmann