Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fbc V3 package #350

Merged
merged 8 commits into from
Sep 19, 2023
Merged

Update Fbc V3 package #350

merged 8 commits into from
Sep 19, 2023

Conversation

fbergmann
Copy link
Member

Description

The FBC v3 package needed to be updated to reflect the latest spec

Motivation and Context

the PR introduces

  • reaction2 on FluxObjective
  • variable2 on UserDefinedConstraintComponent

it also fixes the type of coefficient on the UserDefinedConstraintComponent, since it was a double while
the specification prescribes it to be a SIdRef

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann requested a review from skeating September 15, 2023 10:17
@fbergmann fbergmann marked this pull request as draft September 15, 2023 11:35
@fbergmann fbergmann marked this pull request as ready for review September 15, 2023 14:24
@fbergmann
Copy link
Member Author

the one failing test is due to a test runner not being able to install SWIG. this has no influence to the code here.

@skeating skeating merged commit 9faec63 into development Sep 19, 2023
35 checks passed
@skeating skeating deleted the fbcV3-update branch September 19, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants