Fix behavior of and memory leak from getAllElements functions.

The sublist wasn't being deleted, and its contents weren't being transferred.
sbmlteam · Sep 12, 2024 · 45eab94 · 45eab94
1 parent 2ef3a2a
commit 45eab94
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/sbml/packages/render/sbml/ListOfGlobalRenderInformation.cpp b/src/sbml/packages/render/sbml/ListOfGlobalRenderInformation.cpp
@@ -789,6 +789,8 @@ ListOfGlobalRenderInformation::getAllElements(ElementFilter* filter)
 {
   List* ret = new List();
   List* sublist = ListOf::getAllElements(filter);
+  ret->transferFrom(sublist);
+  delete sublist;
 
   ADD_FILTERED_POINTER(ret, sublist, mDefaultValues, filter);
 

diff --git a/src/sbml/packages/render/sbml/ListOfLocalRenderInformation.cpp b/src/sbml/packages/render/sbml/ListOfLocalRenderInformation.cpp
@@ -760,6 +760,8 @@ ListOfLocalRenderInformation::getAllElements(ElementFilter* filter)
 {
   List* ret = new List();
   List* sublist = ListOf::getAllElements(filter);
+  ret->transferFrom(sublist);
+  delete sublist;
 
   ADD_FILTERED_POINTER(ret, sublist, mDefaultValues, filter);