Fixed a bug that can cause an OutOfBoundsException if debugging is enabled. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
draeger
approved these changes
May 5, 2022
Comment on lines
+1824
to
+1836
| /* | ||
| This code for debugging was commented out because it can cause an OutOfBoundsException during | ||
| the parsing of a model if it contains a lambda element. The reason for this is that | ||
| in astNodeToTree units are derived for the node and for lambda nodes the children | ||
| are necessary for this derivation. The children are not yet present however as addChild() | ||
| is responsible for adding them. | ||
| */ | ||
| /* | ||
| if (isDebugEnabled) { | ||
| logger.debug(" adding child current node: \n" + astNodeToTree(this, "", "")); | ||
| logger.debug(" adding child: \n" + astNodeToTree(child, "", "")); | ||
| } | ||
| */ |
There was a problem hiding this comment.
This fixes a concrete problem but the underlying source still remains. A new tracker item has been created to keep this active. For now, it is solved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Issue
If debugging is activated in log4j and a model is read that contains a lambda element an OutOfBoundsException is thrown. The reason behind this is that during debugging a tree is drawn for each node in the model when addChild() is called on this node that also displays the unit of the node. To display the unit, the unit needs to be derived first and for lambda nodes, all children are required for this derivation. These children however are not yet present as they're being added by the addChild() method itself.
Fix
The code fragment that draws this tree, if debugging is enabled, was commented out.