Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-testcases Related to LookUp Plugin #6

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Swati10-11
Copy link

@sawantpritam Please Review

Then Enter input plugin property: "dataset" with value: "dataset"
Then Enter input plugin property: "table" with value: "bqSourceTable"
Then Click on the Get Schema button
Then Capture the generated Output Schema
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is needed only when we validate columns in preview data. Nor required in this scenario.

Check in all scenarios. Add only if needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Then Verify that the Plugin is displaying an error message: "errorMessageLookUpWithLookupValueFieldNotFound" on the header

@BQ_SOURCE_LOOKUP_TEST @GCS_CSV_LOOKUP_TEST @BQ_SINK_TEST
Scenario:Verify LookUp plugin error when select all Lookup datasets
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : spaces between words

Check description in all scenarios and features.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed spaces between words

Then Enter input plugin property: "Lookupvaluefield" with value: "lookUpValueField"
Then Enter input plugin property: "Outputfield" with value: "lookUpOutputField"
Then Click on the Validate button
Then Verify that the Plugin is displaying an error message: "LookUpPluginErrorWhenSelectAllLookUpDatasets" on the header
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty line at the EOF.

Feature: LookUp - Verification of LookUp Plugin pipeline with BigQuery and GCS as source and BigQuery as target

@BQ_SOURCE_LOOKUP_TEST @GCS_CSV_LOOKUP_TEST @BQ_SINK_TEST
Scenario: To verify complete flow of data extract and transfer from BigQuery and GCS as source to target BigQuery2 with LookUp plugin using GCS lookup dataset.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> to target BigQuery with

Then Open and capture pipeline preview logs
Then Verify the preview run status of pipeline in the logs is "succeeded"
Then Close the pipeline logs
Then Click on the Preview Data link on the Sink plugin node: "BigQueryTable"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add appropriate validation step ->
Either
Verify preview output schema matches the outputSchema captured in properties
Or
Verify sink plugin's Preview Data for Input Records table and the Input Schema matches the Output Schema of Source plugin

Same comment for next scenarios with BigQuery lookup dataset and without output field

targetFieldName=targetField
targetFieldDateFormat=targetFormat
sourceInSecondsOrMilliseconds=secondsOrMilliseconds
Lookupdataset=lookupDataset
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelCase properties , Check all.
i.e Lookupdataset -> lookUpDataset

## LOOKUP-PLUGIN-PROPERTIES-START
lookUpmBQCreateTableQueryFile=testdata/BigQuery/bqLookupCreateTableQuery.txt
lookUpmBQInsertQueryFile=testdata/BigQuery/bqLookUpInsertQuery.txt
lookUpmBQCreateTableQueryFile1=testdata/BigQuery/bqLookUpCreateTableQuery1.txt
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this used ?

## DateTransform-PLUGIN-PROPERTIES-END

## LOOKUP-PLUGIN-PROPERTIES-START
lookUpmBQCreateTableQueryFile=testdata/BigQuery/bqLookupCreateTableQuery.txt
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookUpm -> lookUp

lookUpOutputField1=name
lookUpGCSCsvFile=testdata/file/GCS_CSV_LOOKUP.csv
Lookupdataset=BigQuery
Inputkeyfield=Customer_BloodGroup
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookUpInputKeyField

lookUpValueField1=First_name
lookUpOutputField1=name
lookUpGCSCsvFile=testdata/file/GCS_CSV_LOOKUP.csv
Lookupdataset=BigQuery
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelCase

@sawantpritam
Copy link
Owner

Lookup is not under hydrator repo.

Lookup plugin repo link :
https://github.com/sawantpritam/lookup-transform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants