Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper namespaces for message content #905

Closed
wants to merge 4 commits into from

Conversation

haider-cialfo
Copy link

@haider-cialfo haider-cialfo commented Jun 27, 2019

Fixes #899 #820 #895 #862

@haider-cialfo haider-cialfo mentioned this pull request Jun 27, 2019
@taschetto
Copy link

Can this be merged, please???

@lukaso
Copy link

lukaso commented Dec 4, 2019

Didn't notice this when I added my PR #917. That PR also has a breaking test. Would be very helpful for one of the two PRs to be merged.

@lukaso
Copy link

lukaso commented May 25, 2020

Given the slow pace of incorporating changes, I've created a gem that patches this issue. All you have to do is include it in your Gemfile:

gem 'savon_fixes'

You can find the gem here: https://github.com/lukaso/savon_fixes. It currently covers off these issues and PRs: #916, #899, #820, #895, #862, #905 and #549 (they are all duplicates).

I haven't yet tested it in anger, but all tests pass, so please feedback if there are any issues. Adaptations of PRs here are also welcome.

@sergioisidoro
Copy link

sergioisidoro commented Jun 2, 2020

@pcai @tjarratt @rubiii We do have the same issue, and we have been hacking things along.
Is there anything we can do to speed things up? Any help we can provide?

Should there be any other governance model, given that the gem seems to be on palliative care?

This gem has a significant amount of downloads so it's a major security issue to onboard new people or change ownership. But there has to be something the community can do to help?...

Also, please consider disabling the stale bot.

@olleolleolle
Copy link
Contributor

👋 Thanks for all the work on fixing things, it really helps. ❤️

In order to merge this, even if it is a thing that looks like it's fixing outstanding issues, the test suite has not been amended with new cases.

So, to help this change get merged, add some kind of test (that would fail without this change) to the suite.

@lukaso
Copy link

lukaso commented Jul 20, 2022

This is a duplicate of #917 which has been merged (with test). This should be closed.

@pcai
Copy link
Member

pcai commented Sep 21, 2022

closing per prior comment

@pcai pcai closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Namespace issue
7 participants