Refactor Akami::WSSE to_xml. Signature / Timestamp no longer mutually exclusive. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clean up ugly if-statement in to_xml. * Ensure certificate and timestamp headers are not mutually exclusive. * Add basic signature and signature with timestamp specs.
drn
force-pushed
the
signature-timestamp
branch
from
1daacf9 to
36b26a3
Compare
|
There appears to be a problem here. If the signature and timestamp both present, the timestamp hash is missing it's wsu namespace attribute. The error appears to be in WSSE#security_hash |
|
This is a couple years old and we've just patched this logic in our codebase, so I'm going to close this as it looks like it's not going to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this when integrating with a third-party API. This pull request addresses issues raised in #15
Details: