Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gzip compression for data sent from agent #329

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Oct 19, 2021

What's done:

  • Support in agent
POST /heartbeat HTTP/1.1
Host: host.docker.internal:5100
Accept: application/json,application/json
Accept-Encoding: gzip
Accept-Charset: UTF-8
User-Agent: Ktor client
Content-Type: application/json
Content-Length: 103

Related to #298

### What's done:
* Support in agent
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #329 (c50a3bc) into master (b189f49) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #329      +/-   ##
============================================
- Coverage     75.78%   75.46%   -0.32%     
- Complexity      279      280       +1     
============================================
  Files            36       36              
  Lines          1276     1280       +4     
  Branches         96       98       +2     
============================================
- Hits            967      966       -1     
- Misses          208      211       +3     
- Partials        101      103       +2     
Impacted Files Coverage Δ
...ave/backend/controllers/TestExecutionController.kt 75.00% <100.00%> (+1.66%) ⬆️
.../cqfn/save/orchestrator/docker/ContainerManager.kt 87.32% <100.00%> (+0.18%) ⬆️
...n/save/orchestrator/controller/AgentsController.kt 71.11% <0.00%> (-8.38%) ⬇️
...rg/cqfn/save/orchestrator/service/DockerService.kt 69.56% <0.00%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8226c23...c50a3bc. Read the comment docs.

@orchestr7
Copy link
Member

orchestr7 commented Oct 28, 2021

Looks like it is done, haha :)

@petertrr
Copy link
Member Author

Looks like it is done, haha :)

Not quite, it looks like it only adds support for decoding gzipped responses from the server. I was inspecting traffic with tcpdump, and request body still is displayed in plain text.

* Fixes after merge
* Experiments with deflating with zlib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants