Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display global rating on ContestGlobalRatingView #1187

Merged
merged 22 commits into from
Sep 8, 2022

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Sep 8, 2022

  • Change returned type in OrganizationController from Organization to OrganizationDto
  • Add rating in OrganizationDto
  • Display rating on frontend

Part of #1115

kgevorkyan and others added 12 commits September 6, 2022 17:03
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* Merge master
### What's done:
* WIP
### What's done:
* WIP
### What's done:
* Fix
* Change returned type from controller from Organization to OrganizationDto
* Display rating on frontend
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1187 (7d3c83d) into master (a1d595f) will decrease coverage by 0.09%.
The diff coverage is 5.00%.

@@             Coverage Diff              @@
##             master    #1187      +/-   ##
============================================
- Coverage     42.45%   42.36%   -0.10%     
  Complexity      549      549              
============================================
  Files           181      181              
  Lines          5507     5519      +12     
  Branches        530      532       +2     
============================================
  Hits           2338     2338              
- Misses         2983     2995      +12     
  Partials        186      186              
Impacted Files Coverage Δ
...save/backend/controllers/OrganizationController.kt 37.80% <0.00%> (-1.19%) ⬇️
...urtool/save/frontend/components/basic/ScoreCard.kt 0.00% <ø> (ø)
...mponents/views/contests/ContestGlobalRatingView.kt 0.00% <0.00%> (ø)
...e/frontend/components/views/contests/UserRating.kt 0.00% <0.00%> (-7.70%) ⬇️
...otlin/com/saveourtool/save/frontend/utils/Utils.kt 0.00% <ø> (ø)
...urtool/save/backend/service/OrganizationService.kt 31.70% <16.66%> (-2.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Base automatically changed from feature/update_total_score to master September 8, 2022 10:14
…fe#1115

# Conflicts:
#	save-backend/backend-api-docs.json
#	save-backend/src/main/kotlin/com/saveourtool/save/backend/controllers/OrganizationController.kt
#	save-backend/src/main/kotlin/com/saveourtool/save/backend/service/LnkContestProjectService.kt
#	save-backend/src/main/kotlin/com/saveourtool/save/backend/service/TestExecutionService.kt
#	save-cloud-common/src/commonMain/kotlin/com/saveourtool/save/utils/ExecutionScoreUtils.kt
#	save-frontend/src/main/kotlin/com/saveourtool/save/frontend/components/basic/ExecutionLabels.kt
@petertrr petertrr marked this pull request as ready for review September 8, 2022 10:29
@petertrr petertrr closed this Sep 8, 2022
@petertrr petertrr reopened this Sep 8, 2022
@petertrr petertrr merged commit 5bbaf90 into master Sep 8, 2022
@petertrr petertrr deleted the feature/ratings-on-fe#1115 branch September 8, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants