-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display global rating on ContestGlobalRatingView #1187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Merge master
* Change returned type from controller from Organization to OrganizationDto * Display rating on frontend
save-backend/src/main/kotlin/com/saveourtool/save/backend/service/OrganizationService.kt
Fixed
Show fixed
Hide fixed
save-backend/src/main/kotlin/com/saveourtool/save/backend/service/OrganizationService.kt
Fixed
Show fixed
Hide fixed
save-backend/src/main/kotlin/com/saveourtool/save/backend/service/OrganizationService.kt
Fixed
Show fixed
Hide fixed
save-cloud-common/src/commonMain/kotlin/com/saveourtool/save/entities/OrganizationDto.kt
Fixed
Show fixed
Hide fixed
…tingView and UserRating
… feature/ratings-on-fe#1115
Codecov Report
@@ Coverage Diff @@
## master #1187 +/- ##
============================================
- Coverage 42.45% 42.36% -0.10%
Complexity 549 549
============================================
Files 181 181
Lines 5507 5519 +12
Branches 530 532 +2
============================================
Hits 2338 2338
- Misses 2983 2995 +12
Partials 186 186
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…fe#1115 # Conflicts: # save-backend/backend-api-docs.json # save-backend/src/main/kotlin/com/saveourtool/save/backend/controllers/OrganizationController.kt # save-backend/src/main/kotlin/com/saveourtool/save/backend/service/LnkContestProjectService.kt # save-backend/src/main/kotlin/com/saveourtool/save/backend/service/TestExecutionService.kt # save-cloud-common/src/commonMain/kotlin/com/saveourtool/save/utils/ExecutionScoreUtils.kt # save-frontend/src/main/kotlin/com/saveourtool/save/frontend/components/basic/ExecutionLabels.kt
kgevorkyan
approved these changes
Sep 8, 2022
save-backend/src/main/kotlin/com/saveourtool/save/backend/controllers/OrganizationController.kt
Outdated
Show resolved
Hide resolved
sanyavertolet
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrganizationController
fromOrganization
toOrganizationDto
OrganizationDto
Part of #1115