Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recalculate counters in Execution if value is NOT_APPLICABLE #1170

Merged
merged 7 commits into from
Sep 6, 2022

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Sep 6, 2022

  • Store aggregated metrics in Execution excluding NOT_APPLICABLE metrics from individual test executions (until we can calculate scores for other types of plugins too)
  • Change logic of dispaly on frontend: don't calculate metrics only if all test executions under an execution are NOT_APPLICABLE; otherwise use filtered data from Execution

Related to #1115

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1170 (1d287cb) into master (1ebd285) will increase coverage by 0.15%.
The diff coverage is 84.61%.

❗ Current head 1d287cb differs from pull request most recent head 2fa013f. Consider uploading reports for the commit 2fa013f to get more accurate results

@@             Coverage Diff              @@
##             master    #1170      +/-   ##
============================================
+ Coverage     43.15%   43.30%   +0.15%     
+ Complexity      565      564       -1     
============================================
  Files           179      179              
  Lines          5395     5401       +6     
  Branches        517      514       -3     
============================================
+ Hits           2328     2339      +11     
+ Misses         2882     2878       -4     
+ Partials        185      184       -1     
Impacted Files Coverage Δ
.../save/frontend/components/basic/ExecutionLabels.kt 37.03% <ø> (ø)
...rtool/save/backend/service/TestExecutionService.kt 64.24% <84.61%> (+2.39%) ⬆️
...ol/save/orchestrator/service/HeartBeatInspector.kt 70.68% <0.00%> (-1.73%) ⬇️
...ve/frontend/components/basic/ManageUserRoleCard.kt 39.02% <0.00%> (+4.87%) ⬆️
...otlin/com/saveourtool/save/frontend/utils/Utils.kt 33.33% <0.00%> (+33.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@petertrr petertrr requested a review from nulls September 6, 2022 13:10
@petertrr petertrr enabled auto-merge (squash) September 6, 2022 13:38
@petertrr petertrr disabled auto-merge September 6, 2022 13:40
@petertrr petertrr enabled auto-merge (squash) September 6, 2022 14:00
@petertrr petertrr merged commit 9e1443e into master Sep 6, 2022
@petertrr petertrr deleted the petertrr-patch-2 branch September 6, 2022 14:09
Cheshiriks pushed a commit that referenced this pull request Sep 6, 2022
…1170)

* Store aggregated metrics in Execution excluding `NOT_APPLICABLE` metrics from individual test executions (until we can calculate scores for other types of plugins too)
* Change logic of dispaly on frontend: don't calculate metrics only if all test executions under an execution are `NOT_APPLICABLE`; otherwise use filtered data from Execution

Related to #1115

Co-authored-by: Nariman Abdullin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants