-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't recalculate counters in Execution if value is NOT_APPLICABLE
#1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save-backend/src/main/kotlin/com/saveourtool/save/backend/service/TestExecutionService.kt
Fixed
Show fixed
Hide fixed
save-backend/src/main/kotlin/com/saveourtool/save/backend/service/TestExecutionService.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
============================================
+ Coverage 43.15% 43.30% +0.15%
+ Complexity 565 564 -1
============================================
Files 179 179
Lines 5395 5401 +6
Branches 517 514 -3
============================================
+ Hits 2328 2339 +11
+ Misses 2882 2878 -4
+ Partials 185 184 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
orchestr7
reviewed
Sep 6, 2022
save-backend/src/main/kotlin/com/saveourtool/save/backend/service/TestExecutionService.kt
Outdated
Show resolved
Hide resolved
orchestr7
approved these changes
Sep 6, 2022
nulls
reviewed
Sep 6, 2022
save-backend/src/main/kotlin/com/saveourtool/save/backend/service/TestExecutionService.kt
Outdated
Show resolved
Hide resolved
nulls
reviewed
Sep 6, 2022
save-frontend/src/main/kotlin/com/saveourtool/save/frontend/components/basic/ExecutionLabels.kt
Outdated
Show resolved
Hide resolved
nulls
reviewed
Sep 6, 2022
save-backend/src/main/kotlin/com/saveourtool/save/backend/service/TestExecutionService.kt
Outdated
Show resolved
Hide resolved
nulls
approved these changes
Sep 6, 2022
Cheshiriks
pushed a commit
that referenced
this pull request
Sep 6, 2022
…1170) * Store aggregated metrics in Execution excluding `NOT_APPLICABLE` metrics from individual test executions (until we can calculate scores for other types of plugins too) * Change logic of dispaly on frontend: don't calculate metrics only if all test executions under an execution are `NOT_APPLICABLE`; otherwise use filtered data from Execution Related to #1115 Co-authored-by: Nariman Abdullin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT_APPLICABLE
metrics from individual test executions (until we can calculate scores for other types of plugins too)NOT_APPLICABLE
; otherwise use filtered data from ExecutionRelated to #1115