Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move score from lnk_contest_execution to execution #1156

Merged
merged 12 commits into from
Sep 5, 2022

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Sep 5, 2022

  • Move score from lnk_contest_execution to execution
  • Forbid rerun of TestingType.CONTEST_MODE executions on backend
  • Get best_score directly from lnk_contest_project (this column is not being set yet, will be added in subsequent PRs)

Second part of #1115

* Move `score` from `lnk_contest_execution` to `execution`
* Forbid rerun of `TestingType.CONTEST_MODE` executions
@petertrr petertrr changed the title [WIP] Move score from lnk_contest_execution to execution Move score from lnk_contest_execution to execution Sep 5, 2022
@petertrr petertrr marked this pull request as ready for review September 5, 2022 11:23
@petertrr petertrr requested review from kgevorkyan and nulls September 5, 2022 11:23
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1156 (23546ea) into master (1e86316) will increase coverage by 0.14%.
The diff coverage is 14.28%.

❗ Current head 23546ea differs from pull request most recent head e57c741. Consider uploading reports for the commit e57c741 to get more accurate results

@@             Coverage Diff              @@
##             master    #1156      +/-   ##
============================================
+ Coverage     42.90%   43.04%   +0.14%     
- Complexity      559      561       +2     
============================================
  Files           179      179              
  Lines          5372     5373       +1     
  Branches        518      517       -1     
============================================
+ Hits           2305     2313       +8     
+ Misses         2880     2871       -9     
- Partials        187      189       +2     
Impacted Files Coverage Δ
...backend/controllers/LnkContestProjectController.kt 7.77% <0.00%> (ø)
...save/backend/controllers/RunExecutionController.kt 70.58% <0.00%> (-2.14%) ⬇️
...save/backend/service/LnkContestExecutionService.kt 27.27% <ø> (+7.27%) ⬆️
...l/save/backend/service/LnkContestProjectService.kt 15.00% <0.00%> (-0.79%) ⬇️
...veourtool/save/backend/service/ExecutionService.kt 79.16% <100.00%> (+0.21%) ⬆️
...ol/save/orchestrator/service/HeartBeatInspector.kt 72.41% <0.00%> (+1.72%) ⬆️
...ve/frontend/components/basic/ManageUserRoleCard.kt 48.78% <0.00%> (+14.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@petertrr petertrr enabled auto-merge (squash) September 5, 2022 11:58
@petertrr petertrr merged commit d76428d into master Sep 5, 2022
@petertrr petertrr deleted the feature/rating-ph-1#1115 branch September 5, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants