Prasad #6
Open
Prasad #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prasadrathod Handling multiple URL is already done by Vasu, we will restrict users to pass in the same format which is there right now. The reason being we have modified lighthouse API in dependency as of now, to directly have screenshots in them. |
|
Lets say I have site with 10 different pages. It will be convenient if I can pass all those URL in same json object. |
|
@prasadrathod can you take a fresh pull, modify your code accordingly and then commit it? |
@prasadrathod working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling multiple URLs when test contains URL list