Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/phone validation #230

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fix/phone validation #230

merged 4 commits into from
Oct 2, 2024

Conversation

lauramelos
Copy link

All Submissions:

  • Does your code follow the Extendables standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

Closes #288

How to test the changes in this Pull Request:

  1. Checkout block should be used instead of the shortcode
  2. Go to site, add shippable product and go to checkout
  3. Select local pickup and fill the checkout form
  4. Select Amazon Pay and place order (no validation message)

Other information:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changelog entry

Fix Billing phone number validation on local pickup

@lauramelos lauramelos requested a review from worais September 30, 2024 16:53
@lauramelos lauramelos merged commit b084456 into release/2.5.4 Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants