Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render relevant parts of the screen only #10

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

sassanh
Copy link
Owner

@sassanh sassanh commented Mar 14, 2024

feat: keep a copy of the raw data transferred to the display in config._display.raw_data

This is useful for snapshot tests to snapshot exactly what is rendered on the screen.

This pull request also finalizes partial renders.

feat: keep a copy of the raw data transferred to the display in `config._display.raw_data`
Copy link
Collaborator

@mehrdadfeller mehrdadfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! you can go ahead and merge. I just have sone question: does this "render relevant parts of the screen only" part happen in display.py? does the changes inside the rectangle only get transfered to the display?

@sassanh sassanh merged commit ccc3b46 into main Mar 14, 2024
18 checks passed
@sassanh
Copy link
Owner Author

sassanh commented Mar 14, 2024

@mehrdadfeller No, it only makes each widget render only its own rectangle to the display. With this pull request headless-kivy-pi provides everything needed for partial rendering, but ubo-gui still needs to use HeadlessWidgets for all its components instead of regular kivy Widgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants