Experimental concurrency support #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not well tested and is probably not suitable for merge, but I plan to use this branch a little while in my own project
In theory it should only add new behavior for those who are using cache_to_disk in a (probably) uncommon way. Please see #10 for background
From limited testing, it seems that it's a relatively rare case (<1% of the time) that the lock can't be acquired on the first try. I've not yet encountered a case where the retries were exhausted. In that case (exhausting retries) an exception will be raised. This would probably have to be documented before even being considered for a merge into your project