Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inhibit the dismissal of the popover when a select option is clicked. #258

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vanboom
Copy link

@vanboom vanboom commented Dec 1, 2017

The pointer event point is 0,0 when a select option contained within the popover is clicked. Inhibit the dismissal of the popover based on this.

The pointer event point is 0,0 when a select option contained within the popover is clicked.  Inhibit the dismissal of the popover based on this.
@vanboom vanboom changed the title Inhibit the dismissal of the popover when a select option is clicked. #257 Inhibit the dismissal of the popover when a select option is clicked. Dec 1, 2017
@anatolesaby
Copy link

+1

@yesitsfebreeze
Copy link

@vanboom you should also add a check for the nodeType or else it wont work in IE.

if ((pt.x === 0 && pt.y === 0) || event.target.nodeName === 'OPTION')

@ayjee
Copy link

ayjee commented Mar 27, 2019

+1

q2apro pushed a commit to q2apro/webui-popover that referenced this pull request Aug 15, 2019
sandywalker#258

vanboom on Dec 1, 2017
Douglas Pouk on Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants