Allow downloading uncompressed binaries #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce-opt ADD win_ext to URL template variables
…orm-arch-url-patterns ALLOW platform specific url patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sanathkr!
This project is awesome and I was looking forward to using it for some go packages like gomplate.
I found it was not possible to use this package if the files do not end in
.tar.gz, so I created one specific strategy to handle this and refactored the code a little in order to not use too much memory.Additionally, I found really necessary to make sure file permissions include executable.
I added a small suite of tests for these strategies that we can increase testing progressively every other part of the script, would that be ok?