-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I343 iiif print valkyrization #2187
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds configurations to support tenants in iiif_print PDF splitting feature.
laritakr
force-pushed
the
i343-iiif-print-valkyrization
branch
from
April 17, 2024 21:47
475b198
to
3edef24
Compare
Updates IiifPring::PendingRelationships migration
TODO: get specs to pass and update iiif print gem @ShanaLMoore |
The pipeline says we have 14 spec failures. I ran them all locally and they're passing though. I am going to proceed with the merge and maybe have to deal with the consequences if they appear on main. |
ShanaLMoore
approved these changes
May 9, 2024
ShanaLMoore
added a commit
that referenced
this pull request
May 9, 2024
Copy of PR to see if the pipeline will behave differently. ref: - #2187
Closed
laritakr
pushed a commit
that referenced
this pull request
May 9, 2024
It updates both IiifPrint and Hyrax to alternate branches. This incorporates code changes from #2187, which are needed to be able to work with derivatives.
closing because code is included in #2210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs
Changes proposed in this pull request:
Notes