🎁 Contribute back from HykuUp Knapsack #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files are what we changed in HykuUp Knapsack to get the build, test, and lint workflows working. Also, updating the Hyku submodule to bring in the Valkyrie work.
|
This pipeline is failing because Knapsack's gemfile.lock has blacklight at 6.25. the submodule is 7.29. knapsack's gemfile.lock should reflect its submodule it seems. |
Attempt to resolve error on pipeline: mv: cannot stat 'rspec.xml': No such file or directory
ShanaLMoore
force-pushed
the
prime_main
branch
2 times, most recently
from
1942c03 to
5b84eed
Compare
Ultimately the actions step needs to updated to not run if rspec.xml doesn't exist. We've added specs but there isn't enough to satisfy the pipeline since its processes splits into three test tasks. We'd need at least three separate spec files.
ShanaLMoore
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files are what we changed in HykuUp Knapsack to get the build, test, and lint workflows working. Also, updating the Hyku submodule to bring in the Valkyrie work.