Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Run bundle when migrations present #14

Closed
wants to merge 1 commit into from

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Mar 29, 2024

Prior to this commit, we might have a situation where the initialize_app
container's gems are not what is indicated by the Gemfile.lock. Which
creates problems when we run the bundle exec rails db:create; namely
the error will mention that we don't have the gem installed.

We can circumvent this via different docker compose files; however, it
seems reasonable to demand that we bundle before we execute bundle exec; especially when we consider the fact that we're not always
running migrations.

Prior to this commit, we might have a situation where the initialize_app
container's gems are not what is indicated by the Gemfile.lock.  Which
creates problems when we run the `bundle exec rails db:create`; namely
the error will mention that we don't have the gem installed.

We can circumvent this via different docker compose files; however, it
seems reasonable to demand that we `bundle` before we execute `bundle
exec`; especially when we consider the fact that we're not always
running migrations.
@jeremyf jeremyf requested a review from orangewolf March 29, 2024 15:48
@jeremyf jeremyf closed this Apr 2, 2024
@jeremyf jeremyf deleted the run-bundle-when-migrations-present branch April 2, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant