Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: integration test via github action #968

Merged
merged 29 commits into from
Feb 28, 2024
Merged

infra: integration test via github action #968

merged 29 commits into from
Feb 28, 2024

Conversation

Shinigami92
Copy link
Collaborator

@Shinigami92 Shinigami92 added c: infra Changes to our infrastructure or project setup c: test p: 1-normal Nothing urgent labels Feb 28, 2024
@Shinigami92 Shinigami92 added this to the v7.0 milestone Feb 28, 2024
@Shinigami92 Shinigami92 self-assigned this Feb 28, 2024
@Shinigami92 Shinigami92 marked this pull request as draft February 28, 2024 17:10
@Shinigami92 Shinigami92 marked this pull request as ready for review February 28, 2024 17:21
@Shinigami92
Copy link
Collaborator Author

I compared https://github.com/salsita/node-pg-migrate/actions/runs/8084473883/job/22089812640?pr=968#step:8:1 against https://app.circleci.com/pipelines/github/salsita/node-pg-migrate/1261/workflows/269833a1-f71d-491e-a658-892e87e2d3ae/jobs/40897 and it looks really the same

So I feel comfy about that this is working correctly 🚀

@Shinigami92 Shinigami92 marked this pull request as draft February 28, 2024 18:14
@Shinigami92
Copy link
Collaborator Author

🎉 🎉 🎉

oof that was cumbersome

@Shinigami92 Shinigami92 marked this pull request as ready for review February 28, 2024 21:57
@Shinigami92
Copy link
Collaborator Author

Deactivated the CircleCI Webhook
The badges in readme will be changed in a later PR

ST-DDT
ST-DDT approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Shinigami92 Shinigami92 merged commit e7f2b5e into main Feb 28, 2024
31 checks passed
@Shinigami92 Shinigami92 deleted the infra/integration-test-via-github-actions branch February 28, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: infra Changes to our infrastructure or project setup c: test p: 1-normal Nothing urgent
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Shinigami92 @ST-DDT