fix: migration files not sorted by timestamp when using glob #1299
Conversation
Signed-off-by: Benjamin Kroeger <[email protected]>
|
Does this need a test? And if not -> why? |
|
somehow I was expecting this question :) |
I would need to investigate by jumping into the codebase and spending time into it |
|
haven't had the capacity to get back to this yet. Still not forgotten though. I consider this a bugfix. |
I originally thought that sorting migration files by their absolute path is good enough. Working with this has painfully taught me otherwise.
So, this changes the sorting of matched files to be done exactly the same way as the non-glob version does it (by the numeric value of the
timestampprefix in the filename first - and just locale string compare otherwise (when both timestamps represent the same numeric value).Result is still an array of absolute paths.