New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: @W-16299313 PoC iframe keepAlive #460

Draft

rwaldron wants to merge 1 commit into main from rwaldron/keepalive

Contributor

rwaldron commented Aug 2, 2024

No description provided.

github-actions bot commented Aug 2, 2024

Metric	Coverage Percent	Covered / Total
Statements	81.6%	( 856/1049 )
Branches	56.06%	( 199/355 )
Functions	73.87%	( 82/111 )
Lines	81.38%	( 826/1015 )

Total	73.23%

See detailed coverage


          feat: @W-16299313 PoC iframe keepAlive

dcbe2db

rwaldron force-pushed the rwaldron/keepalive branch from 8134aac to dcbe2db Compare

August 5, 2024 19:18

github-actions bot commented Aug 5, 2024

Metric	Coverage Percent	Covered / Total
Statements	81.35%	( 842/1035 )
Branches	56%	( 196/350 )
Functions	73.87%	( 82/111 )
Lines	81.12%	( 812/1001 )

Total	73.09%

See detailed coverage

jdalton reviewed

View reviewed changes

packages/near-membrane-dom/src/browser-realm.ts

+                      iframeStash = ReflectApply(ElementProtoAttachShadow, host, [
+                          { mode: 'closed' },
+                      ]) as ShadowRoot;

Contributor

jdalton Nov 14, 2024

So cool 🎉 !

Contributor

jdalton commented Nov 14, 2024

Love this approach. A large chunk of src/membrane.ts can be removed too:
https://github.com/salesforce/near-membrane/blob/v0.13.12/packages/near-membrane-base/src/membrane.ts#L1686-L1994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet