fix: @W-17310064 [LWS] Add TextDecoder to near-membrane maxPerfMode k…

…eys to fix "TypeError: parameter 1 is not of type 'ArrayBuffer'"
salesforce · Nov 25, 2024 · 6954b9d · 6954b9d
1 parent 8fd3afa
commit 6954b9d
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 0 deletions.
diff --git a/packages/near-membrane-base/src/intrinsics.ts b/packages/near-membrane-base/src/intrinsics.ts
@@ -124,6 +124,8 @@ function getESGlobalKeys(maxPerfMode: boolean) {
             'Request',
             'Response',
             'SubtleCrypto',
+            'TextDecoder',
+            'TextEncoder',
             'URL',
             'XMLHttpRequest',
         ],

diff --git a/test/membrane/binary-data.spec.js b/test/membrane/binary-data.spec.js
@@ -398,6 +398,46 @@ describe('Binary Data and maxPerfMode:', () => {
         });
     });
 
+    describe('TextDecoder:', () => {
+        beforeEach(createBaseLineMaxCompatModeEnvironment);
+
+        it('can decode from typed array', () => {
+            const env = createVirtualEnvironment(window, {
+                endowments: Object.getOwnPropertyDescriptors({ expect }),
+            });
+
+            env.evaluate(untrusted('text-decoder.js'));
+        });
+        it('can decode from typed array, when maxPerfMode is true', () => {
+            const env = createVirtualEnvironment(window, {
+                endowments: Object.getOwnPropertyDescriptors({ expect }),
+                maxPerfMode: true,
+            });
+
+            env.evaluate(untrusted('text-decoder.js'));
+        });
+    });
+
+    describe('TextEncoder:', () => {
+        beforeEach(createBaseLineMaxCompatModeEnvironment);
+
+        it('can encode into typed array', () => {
+            const env = createVirtualEnvironment(window, {
+                endowments: Object.getOwnPropertyDescriptors({ expect }),
+            });
+
+            env.evaluate(untrusted('text-encoder.js'));
+        });
+        it('can encode into typed array, when maxPerfMode is true', () => {
+            const env = createVirtualEnvironment(window, {
+                endowments: Object.getOwnPropertyDescriptors({ expect }),
+                maxPerfMode: true,
+            });
+
+            env.evaluate(untrusted('text-encoder.js'));
+        });
+    });
+
     describe('FileSaver library:', () => {
         beforeEach(createBaseLineMaxCompatModeEnvironment);
 

diff --git a/test/membrane/untrusted/binary-data/text-decoder.js b/test/membrane/untrusted/binary-data/text-decoder.js
@@ -0,0 +1 @@
+new TextDecoder().decode(Uint8Array.from('Hello World!'.split('').map(letter => letter.charCodeAt(0))));
diff --git a/test/membrane/untrusted/binary-data/text-encoder.js b/test/membrane/untrusted/binary-data/text-encoder.js
@@ -0,0 +1 @@
+new TextEncoder().encodeInto('hello', new Uint8Array(8), 0);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		new TextDecoder().decode(Uint8Array.from('Hello World!'.split('').map(letter => letter.charCodeAt(0))));
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		new TextEncoder().encodeInto('hello', new Uint8Array(8), 0);