Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the event handlers parameter types for the color-picker component. #3021

Closed
wants to merge 1 commit into from
Closed

Fix the event handlers parameter types for the color-picker component. #3021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions components/color-picker.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ declare module '@salesforce/design-system-react/components/color-picker' {
* _Tested with Mocha framework._
*/
events?: Partial<{
onChange?: (v: any) => any;
onClose?: (v: any) => any;
onOpen?: (v: any) => any;
onRequestClose?: (v: any) => any;
onChange?: (event: React.SyntheticEvent, v: any) => any;
onClose?: (event: React.SyntheticEvent, v: any) => any;
onOpen?: (event: React.SyntheticEvent, v: any) => any;
onRequestClose?: (event: React.SyntheticEvent, v: any) => any;
onRequestOpen?: (v: any) => any;
onValidateColor?: (v: any) => any;
onValidateWorkingColor?: (v: any) => any;
onWorkingColorChange?: (v: any) => any;
onWorkingColorChange?: (event: React.SyntheticEvent, v: any) => any;
}>;
/**
* By default, dialogs will flip their alignment (such as bottom to top) if they extend beyond a boundary element such as a scrolling parent or a window/viewpoint. `hasStaticAlignment` disables this behavior and allows this component to extend beyond boundary elements. _Not tested._
Expand Down