Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if live engagement is when SC Intention #1199

Draft
wants to merge 1 commit into
base: feature/entry-widget-and-secure-conversations-v2
Choose a base branch
from
Draft

Check if live engagement is when SC Intention #1199

wants to merge 1 commit into from

Conversation

AH-MOC
Copy link
Contributor

@AH-MOC AH-MOC commented Dec 30, 2024

Jira issue:
https://glia.atlassian.net/browse/MOB-3888

What was solved?
Check if live engagement is when SC Intention.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@AH-MOC AH-MOC requested a review from a team as a code owner December 30, 2024 20:40
@AH-MOC AH-MOC requested a review from DavDo December 30, 2024 20:40
DavDo
DavDo requested changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@DavDo DavDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking merge just in case, until we decide this.

@AH-MOC AH-MOC marked this pull request as draft December 31, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavDo DavDo DavDo requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AH-MOC @DavDo