refs #34 Fixed checking method not exists

sajya · Jul 12, 2022 · bd3b8e2 · bd3b8e2
1 parent d646a01
commit bd3b8e2
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/src/Guide.php b/src/Guide.php
@@ -128,6 +128,7 @@ public function findProcedure(Request $request): ?string
 
         return $this->map
             ->filter(fn (string $procedure) => $this->getProcedureName($procedure) === $class)
+            ->filter(fn (string $procedure) => method_exists($procedure, $method))
             ->filter(fn (string $procedure) => $this->checkExistPublicMethod($procedure, $method))
             ->map(fn (string $procedure)    => Str::finish($procedure, self::DEFAULT_DELIMITER . $method))
             ->first();

diff --git a/tests/Expected/Requests/testCallNoExistMethod.json b/tests/Expected/Requests/testCallNoExistMethod.json
@@ -0,0 +1,5 @@
+{
+    "jsonrpc": "2.0",
+    "method": "fixture@undefined",
+    "id": 1
+}
diff --git a/tests/Expected/Responses/testCallNoExistMethod.json b/tests/Expected/Responses/testCallNoExistMethod.json
@@ -0,0 +1,9 @@
+{
+    "error": {
+        "code": -32601,
+        "data": null,
+        "message": "Method not found"
+    },
+    "id": "1",
+    "jsonrpc": "2.0"
+}
diff --git a/tests/Unit/ExpectedTest.php b/tests/Unit/ExpectedTest.php
@@ -82,6 +82,7 @@ public function exampleCalls(): Generator
         yield ['testCallCloseMethod'];
         yield ['testRuntimeError'];
         yield ['testInvalidRequestException'];
+        yield ['testCallNoExistMethod'];
 
         // Binding
         yield ['testBindDeepValue',];