feat: Added appset information to GitHub and GitLab PRs

[saidsef]

What this PR does / why we need it:

• feat: Added appset information to GitHub and GitLab PRs

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added CI tests to cover my changes.
• All new and existing tests passed.

[saidsef]

/code pr

[saidsef]

🤖
The PR adds useful metadata about pull requests/merge requests to both GitHub and GitLab ApplicationSet templates via the info field. The changes look good overall and add valuable context that can be used for tracking and reference.

A minor enhancement suggestion for github-pr.yml and gitlab-mr.yml:

info:
  - name: url      # Add the PR/MR URL for quick reference
    value: '{{ $dqf }}html_url{{ $dqb }}'  # For GitHub
    # value: '{{ $dqf }}web_url{{ $dqb }}'  # For GitLab

Adding the PR/MR URL would make it easier to quickly navigate to the source of changes from the Argo CD UI.

_{> claude-3-5-sonnet-20241022 [pr | 0]}

[saidsef]

/code pr

[saidsef]

🤖
This PR looks good overall. It adds useful metadata to both GitHub PR and GitLab MR ApplicationSet templates. A few observations:

1. The version bump from 0.14.0 to 0.15.0 is appropriate given the new feature addition.

2. Good addition of the info section to both templates which includes:

   • Author
   • Branch
   • Target branch
   • PR/MR number

3. The changes are consistently applied across both GitHub and GitLab templates, maintaining parity.

The only minor suggestion I would make:

# Consider renaming 'pull_request' to 'number' in GitLab template 
# since GitLab uses 'merge request' terminology
- name: pull_request   # Could be 'merge_request' instead
  value: '{{ $dqf }}number{{ $dqb }}'

Otherwise, this is a clean enhancement that improves observability of PR/MR deployments in ArgoCD.

_{> claude-3-5-sonnet-20241022 [pr | 2]}

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files

[saidsef]

/code pr

[saidsef]

🤖
Here's my review of the changes:

1. ApplicationSet Info Addition (Patch 1/2):

• Good addition of info fields to both GitHub PR and GitLab MR templates
• The changes are symmetrical and well-structured
• Minor suggestion: Consider adding a comment explaining what these info fields are used for

2. Chart Version Update:

• Appropriate version bump from 0.14.0 to 0.15.0
• Clear changelog entry describing the changes

3. CI Changes (Patch 2/2):

• Good: Added necessary permissions for dependency review workflow
• ✨ Nice upgrade of kubectl and node versions to 1.30.4
• Both kubectl and node versions are now aligned properly

The changes look solid overall. Just ensure you've tested the new info fields with both GitHub and GitLab to verify the variable substitution works as expected.

Files changed look appropriate and changes are focused. No major issues found.

_{> claude-3-5-sonnet-20241022 [pr | 2]}