chore(cleanup): remove legacy bootstrap step (datahub-project#11494)

sagar-salvi-apptware · Sep 30, 2024 · dea17d4 · dea17d4
1 parent b473cf8
commit dea17d4
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 925 deletions.
diff --git a/...e-consumer/src/main/java/com/linkedin/metadata/kafka/boot/MCLBootstrapManagerFactory.java b/...e-consumer/src/main/java/com/linkedin/metadata/kafka/boot/MCLBootstrapManagerFactory.java
@@ -11,7 +11,6 @@
 import javax.annotation.Nonnull;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Qualifier;
-import org.springframework.beans.factory.annotation.Value;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Conditional;
 import org.springframework.context.annotation.Configuration;
@@ -27,9 +26,6 @@ public class MCLBootstrapManagerFactory {
 
   @Autowired private ConfigurationProvider _configurationProvider;
 
-  @Value("${bootstrap.upgradeDefaultBrowsePaths.enabled}")
-  private Boolean _upgradeDefaultBrowsePathsEnabled;
-
   @Bean(name = "mclBootstrapManager")
   @Scope("singleton")
   @Nonnull

diff --git a/...e-consumer/src/main/java/com/linkedin/metadata/kafka/boot/MCPBootstrapManagerFactory.java b/...e-consumer/src/main/java/com/linkedin/metadata/kafka/boot/MCPBootstrapManagerFactory.java
@@ -11,7 +11,6 @@
 import javax.annotation.Nonnull;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Qualifier;
-import org.springframework.beans.factory.annotation.Value;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Conditional;
 import org.springframework.context.annotation.Configuration;
@@ -27,9 +26,6 @@ public class MCPBootstrapManagerFactory {
 
   @Autowired private ConfigurationProvider _configurationProvider;
 
-  @Value("${bootstrap.upgradeDefaultBrowsePaths.enabled}")
-  private Boolean _upgradeDefaultBrowsePathsEnabled;
-
   @Bean(name = "mcpBootstrapManager")
   @Scope("singleton")
   @Nonnull

diff --git a/metadata-service/configuration/src/main/resources/application.yaml b/metadata-service/configuration/src/main/resources/application.yaml
@@ -343,12 +343,6 @@ incidents:
     consumerGroupSuffix: ${INCIDENTS_HOOK_CONSUMER_GROUP_SUFFIX:}
 
 bootstrap:
-  upgradeDefaultBrowsePaths:
-    enabled: ${UPGRADE_DEFAULT_BROWSE_PATHS_ENABLED:false} # enable to run the upgrade to migrate legacy default browse paths to new ones
-  backfillBrowsePathsV2:
-    enabled: ${BACKFILL_BROWSE_PATHS_V2:false} # Enables running the backfill of browsePathsV2 upgrade step. There are concerns about the load of this step so hiding it behind a flag. Deprecating in favor of running through SystemUpdate
-  reprocessDefaultBrowsePathsV2:
-    enabled: ${REPROCESS_DEFAULT_BROWSE_PATHS_V2:false} # reprocess V2 browse paths which were set to the default: {"path":[{"id":"Default"}]}
   policies:
     file: ${BOOTSTRAP_POLICIES_FILE:classpath:boot/policies.json}
     # eg for local file

diff --git a/...factories/src/main/java/com/linkedin/metadata/boot/factories/BootstrapManagerFactory.java b/...factories/src/main/java/com/linkedin/metadata/boot/factories/BootstrapManagerFactory.java
@@ -9,7 +9,6 @@
 import com.linkedin.metadata.boot.BootstrapManager;
 import com.linkedin.metadata.boot.BootstrapStep;
 import com.linkedin.metadata.boot.dependencies.BootstrapDependency;
-import com.linkedin.metadata.boot.steps.BackfillBrowsePathsV2Step;
 import com.linkedin.metadata.boot.steps.IndexDataPlatformsStep;
 import com.linkedin.metadata.boot.steps.IngestDataPlatformInstancesStep;
 import com.linkedin.metadata.boot.steps.IngestDataPlatformsStep;
@@ -25,7 +24,6 @@
 import com.linkedin.metadata.boot.steps.RestoreColumnLineageIndices;
 import com.linkedin.metadata.boot.steps.RestoreDbtSiblingsIndices;
 import com.linkedin.metadata.boot.steps.RestoreGlossaryIndices;
-import com.linkedin.metadata.boot.steps.UpgradeDefaultBrowsePathsStep;
 import com.linkedin.metadata.boot.steps.WaitForSystemUpdateStep;
 import com.linkedin.metadata.entity.AspectMigrationsDao;
 import com.linkedin.metadata.entity.EntityService;
@@ -89,12 +87,6 @@ public class BootstrapManagerFactory {
 
   @Autowired private ConfigurationProvider _configurationProvider;
 
-  @Value("${bootstrap.upgradeDefaultBrowsePaths.enabled}")
-  private Boolean _upgradeDefaultBrowsePathsEnabled;
-
-  @Value("${bootstrap.backfillBrowsePathsV2.enabled}")
-  private Boolean _backfillBrowsePathsV2Enabled;
-
   @Value("${bootstrap.policies.file}")
   private Resource _policiesResource;
 
@@ -154,14 +146,6 @@ protected BootstrapManager createInstance(
                 ingestDataTypesStep,
                 ingestEntityTypesStep));
 
-    if (_upgradeDefaultBrowsePathsEnabled) {
-      finalSteps.add(new UpgradeDefaultBrowsePathsStep(_entityService));
-    }
-
-    if (_backfillBrowsePathsV2Enabled) {
-      finalSteps.add(new BackfillBrowsePathsV2Step(_entityService, _searchService));
-    }
-
     return new BootstrapManager(finalSteps);
   }
 }
diff --git a/...e/factories/src/main/java/com/linkedin/metadata/boot/steps/BackfillBrowsePathsV2Step.java b/...e/factories/src/main/java/com/linkedin/metadata/boot/steps/BackfillBrowsePathsV2Step.java
diff --git a/...ctories/src/main/java/com/linkedin/metadata/boot/steps/UpgradeDefaultBrowsePathsStep.java b/...ctories/src/main/java/com/linkedin/metadata/boot/steps/UpgradeDefaultBrowsePathsStep.java