Skip to content

Commit

Permalink
fix: PR Comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sagar-salvi-apptware committed Oct 2, 2024
1 parent 6fb8c66 commit 04688c6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions metadata-ingestion/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,6 @@
# LookML files with spaces between an item and the following comma.
# See https://github.com/joshtemple/lkml/issues/73.
"lkml>=1.3.4",
# Fixes https://github.com/looker-open-source/sdk-codegen/issues/1410 , cattrs appears to have introduced a breaking change starting in version 23.2.
"cattrs>=1.3,<23.2",
*sqlglot_lib,
"GitPython>2",
"python-liquid",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ def from_api( # noqa: C901
logger.warning(
f"Failed to extract explore {explore_name} from model {model}, Error: {e}"
)
reporter.report_warning(
reporter.warning(
title=f"Failed to extract explore {explore_name} from model {model}",
message="Encountered exception while attempting to find dependent views for this chart",
context=f"Explore: {explore_name}, Mode: {model}",
Expand Down

0 comments on commit 04688c6

Please sign in to comment.