Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better logging, hide empty lp #1126

Merged
merged 2 commits into from
Jun 23, 2022
Merged

better logging, hide empty lp #1126

merged 2 commits into from
Jun 23, 2022

Conversation

hammeiam
Copy link
Contributor

Log when a stake/unstake fails, hide empty lp balance from the reward claim screen

Resolves #1124 #1125

@hammeiam hammeiam requested a review from a team June 23, 2022 19:38
@hammeiam hammeiam marked this pull request as ready for review June 23, 2022 19:38
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1126 (adf2c17) into master (d9c2de0) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
- Coverage   10.27%   10.25%   -0.03%     
==========================================
  Files         153      153              
  Lines        5506     5519      +13     
  Branches     1744     1745       +1     
==========================================
  Hits          566      566              
- Misses       4938     4951      +13     
  Partials        2        2              
Impacted Files Coverage Δ
src/pages/Farm/ClaimRewardsDlg.tsx 0.00% <0.00%> (ø)
src/pages/Farm/StakeDialog.tsx 0.00% <0.00%> (ø)
src/utils/index.ts 46.41% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c2de0...adf2c17. Read the comment docs.

@hammeiam hammeiam enabled auto-merge (squash) June 23, 2022 19:54
@hammeiam hammeiam merged commit 1909426 into master Jun 23, 2022
@hammeiam hammeiam deleted the david/minor-farm-tweaks branch June 23, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LP Balance: not showing value in Farm page, dialog component - can hide it (P1)
2 participants