Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography (WIP) #3

Open
wants to merge 3 commits into
base: theme-ui-update
Choose a base branch
from
Open

Typography (WIP) #3

wants to merge 3 commits into from

Conversation

taggartbg
Copy link
Contributor

@taggartbg taggartbg commented Oct 25, 2021

  • Add @font-face sources and required font files
  • Add base styles to theme
  • Add styleguide-defined variants

ISSUES:

  • Themed.h1 and Themed.h2 simply do not seem to respect the Theme Specification. They get the css rule "css-0" with no styles on it. I moved them to Text Variants, but let me know your thoughts. We can make wrapping components for the primitives and apply the styles with sx, but I was surprised that the Themed component doesn't seem to work.

TODO:

  • Merge base branch and re-target

  • Figure out the best way to distribute the font files. I see 3 ways we could go with this:

    1. Distribute our /public folder to the npm package, require the consuming package to re-host them
    2. Figure out a way to load them through the module system so that they're caught by postcss (I'm not convinced this will work, but it'd be really nice if it did)
    3. Host the files on a cdn (would need to check the TOS)
      3.5. Does whoever we bought the files from have a public CDN we can use?

    EDIT: Spoke offline, we will have the consuming package source the font files, this is ready-for-review

@taggartbg taggartbg added the question Further information is requested label Oct 25, 2021
@taggartbg taggartbg requested a review from hammeiam October 25, 2021 18:55
@taggartbg
Copy link
Contributor Author

Also TODO: Once our approach to the static files / global styles are finalized, we need update the README for the consuming application

@taggartbg taggartbg marked this pull request as draft October 25, 2021 19:05
@taggartbg taggartbg marked this pull request as ready for review November 10, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant