Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES:
Themed.h1
andThemed.h2
simply do not seem to respect the Theme Specification. They get the css rule "css-0" with no styles on it. I moved them to Text Variants, but let me know your thoughts. We can make wrapping components for the primitives and apply the styles withsx
, but I was surprised that the Themed component doesn't seem to work.TODO:
Merge base branch and re-target
Figure out the best way to distribute the font files. I see 3 ways we could go with this:Distribute our /public folder to the npm package, require the consuming package to re-host themFigure out a way to load them through the module system so that they're caught by postcss (I'm not convinced this will work, but it'd be really nice if it did)Host the files on a cdn (would need to check the TOS)3.5.
Does whoever we bought the files from have a public CDN we can use?EDIT: Spoke offline, we will have the consuming package source the font files, this is ready-for-review