Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for increasing and decreasing interval #168

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

arpandaze
Copy link
Contributor

Closes #67

Please let me know if any change is necessary!

@sachaos
Copy link
Owner

sachaos commented Dec 20, 2024

Cool! Thank you!
I'll check soon!

@sachaos
Copy link
Owner

sachaos commented Dec 20, 2024

When I specified -n 100ms and increase to 600ms, I couldn't back to 100ms by decreasing feature.

@arpandaze
Copy link
Contributor Author

That should be because I have set min interval to be 500ms. Also step is 500ms. Maybe step should be configurable from config?

@sachaos
Copy link
Owner

sachaos commented Dec 21, 2024

Yes, I think so.

@arpandaze
Copy link
Contributor Author

Yes, I think so.

I have updated to make interval step and min interval configurable.

Copy link
Owner

@sachaos sachaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachaos
Copy link
Owner

sachaos commented Dec 22, 2024

Thank you!
I'll fix some code, and release it!

@sachaos sachaos merged commit 9ef1997 into sachaos:master Dec 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature-request] Shortcut to increase/decrease the interval
2 participants