Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin php-cs-fixer to 3.63.2 in 5.1 branch #248

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 6, 2024

We still support PHP 7.1 7.2 7.3 here, and that uses the old php-cs-fixer v2.
The new php-cs-fixer 3.64 wants to make changes to trailing-comma in list() - we want to avoid doing that in this old 5.1 branch, because php-cs-fixer v2 does not like it.

There is no need for any new release of the 5.1 series - https://github.com/sabre-io/http/releases/tag/5.1.12 has full support for PHP 8.4

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.14%. Comparing base (7a9f650) to head (ff1b7b9).
Report is 5 commits behind head on 5.1.

Additional details and impacted files
@@            Coverage Diff            @@
##                5.1     #248   +/-   ##
=========================================
  Coverage     94.14%   94.14%           
  Complexity      266      266           
=========================================
  Files            15       15           
  Lines           871      871           
=========================================
  Hits            820      820           
  Misses           51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis phil-davis merged commit 4c2a2c0 into sabre-io:5.1 Sep 6, 2024
11 checks passed
@phil-davis phil-davis deleted the pin-php-cs-fixer-3.63.2 branch September 6, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant