Skip to content

Commit

Permalink
Update REVIEWING.md
Browse files Browse the repository at this point in the history
  • Loading branch information
holylovenia authored Jan 19, 2024
1 parent d46b52c commit fd2e9e0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion REVIEWING.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ Check the following before approving:
The objective of datasheet review is to ensure that all dataloaders in SEACrowd has correctness to the HF Dataloader Structure & SEACrowd defined schema and config and follow similar code format and/or style.

### Dataloader Check
1. Metadata correctness. (ensure Tasks, Languages, HOME_URL, DATA_URL is used).
1. Metadata correctness. (ensure Tasks, Languages, HOME_URL, DATA_URL is used). Make sure the dataloader also has `__init__.py`.
2. All subsets are implemented correctly to respective dataloader issue and according to SEACrowd Schema definition (has both `source` and `seacrowd` schema -- if a given task has its SEACrowd Schema, else can raise it to reviewers/mods).
3. Pass the test scripts defined in `tests` folder.
4. Pass manual check.
Expand Down

0 comments on commit fd2e9e0

Please sign in to comment.