Fix: wait until config has settled before starting services

Ensure ceph.conf points to the correct run dir

Fixes: canonical#356

Signed-off-by: Peter Sabaini <[email protected]>

snapcraft/commands/common

@@ -0,0 +1,20 @@
+wait_for_config() {
+
+  local confpath="${SNAP_DATA}/conf/ceph.conf"
+  local search_str="^run dir = ${SNAP_DATA}/run"
+  local max_attempts=300
+  local attempt=0
+
+  while [ $attempt -lt $max_attempts ]; do
+    if [ -f "${confpath}" ]; then
+      if grep -q "${search_str}" "${confpath}"; then
+        return 0
+      fi
+    fi
+    attempt=$((attempt + 1))
+    sleep 2
+  done
+
+  echo "No updated conf found in ${confpath}"
+  return 1
+}

snapcraft/commands/mds.start

@@ -1,2 +1,7 @@
 #!/bin/sh
+
+. "${SNAP}/commands/common"
+
+wait_for_config
+
 exec ceph-mds -f --cluster ceph --id "$(hostname)"

snapcraft/commands/mgr.start

@@ -1,2 +1,7 @@
 #!/bin/sh
+
+. "${SNAP}/commands/common"
+
+wait_for_config
+
 exec ceph-mgr -f --cluster ceph --id "$(hostname)"

snapcraft/commands/mon.start

@@ -1,2 +1,7 @@
 #!/bin/sh
+
+. "${SNAP}/commands/common"
+
+wait_for_config
+
 exec ceph-mon -f --cluster ceph --id "$(hostname)"

snapcraft/commands/osd.start

@@ -6,6 +6,7 @@ export SNAP_CURRENT="$(realpath "${SNAP_DATA}/..")/current"
 echo $$ > "${SNAP_CURRENT}/run/ceph-osd.pid"
 cd "${SNAP}"
 
+. "${SNAP}/commands/common"
 
 maybe_unlock() {
     dev="${1:?missing}"
@@ -59,5 +60,7 @@ spawn() {
 }
 trap spawn HUP
 
+wait_for_config
+
 spawn
 exit 0

snapcraft/commands/rados

@@ -1,2 +1,3 @@
 #!/bin/sh
+
 exec "${SNAP}/bin/rados" "$@"

snapcraft/commands/rgw.start

@@ -1,4 +1,9 @@
 #!/bin/sh
+
+. "${SNAP}/commands/common"
+
+wait_for_config
+
 conf="${SNAP_DATA}/conf/radosgw.conf"
 
 if [ -n "${conf}" ] ; then