Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced 'of' with 'or' #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replaced 'of' with 'or' #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project-ideas/fulfillment-center-mgmt/PartyGroup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Rest API for managing PartyGroup.

There is no reason to create Party independent of PartyGroup of Person. We should see it as Abstract class, it cannot be instantiated on its own.
There is no reason to create Party independent of PartyGroup or Person. We should see it as Abstract class, it cannot be instantiated on its own.

createPartyGroup should accept all fields in Party and PartyGroup entity.
Keep it simple, If you pass in partyId, and insert fails because of duplicate key, it fails, return natural error. Don't process it in anyways.
Expand Down