Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XSS vulnerability in VirtualSelect #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

izambasiron
Copy link

@izambasiron izambasiron commented Nov 7, 2024

Fixes #365

Update the secureText method in src/virtual-select.js to enhance XSS protection.

  • Modify the return statement to use Utils.replaceDoubleQuotesWithHTML(this.$secureDiv.innerHTML) instead of this.$secureDiv.innerHTML.

For more details, open the Copilot Workspace session.

Fixes sa-si-dev#365

Update the `secureText` method in `src/virtual-select.js` to enhance XSS protection.

* Modify the return statement to use `Utils.replaceDoubleQuotesWithHTML(this.$secureDiv.innerHTML)` instead of `this.$secureDiv.innerHTML`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/sa-si-dev/virtual-select/issues/365?shareId=XXXX-XXXX-XXXX-XXXX).
@gnbm gnbm requested a review from sa-si-dev November 15, 2024 11:41
@gnbm
Copy link
Collaborator

gnbm commented Dec 16, 2024

@izambasiron please create some automated test scenarios to make sure the change will not break any use case as well as make it more future proof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XSS Vulnerability in VirtualSelect’s options Configuration
2 participants