Throw an Error in async functions instead of returning an object #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @s0ftik3!
I noticed that in the asynchronous methods of the
Reverso
class, you return objects instead of throwing an error. As a result, the returned promise is resolved with an object that indicates an error occurred. In the event of an error in your code, it is better to throw an instance of theError
class.After my changes it would be possible to use
catch
method of thePromise
class, for example:ref: https://javascript.info/async-await