Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Number Formatting Order in Customization #854

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

mhl98
Copy link
Contributor

@mhl98 mhl98 commented Aug 30, 2024

Describe the issue/change

Problem: When typing Persian numbers from 1 to 9, there is an issue with how the numbers are displayed. Currently, the numbers appear in an incorrect order or format. For example, if you type a sequence of numbers like ۱۲۳,۴۵۶,۷۸۹ it appears as ۱۲۳,۵۶۸,۹۷۴.

Screen.Recording.2024-08-30.at.3.08.03.PM.mov

Expected Behavior: After the fix, when typing Persian numbers from 1 to 9, they should be displayed in the correct order and format, like ۱۲۳,۴۵۶,۷۸۹.

Screen.Recording.2024-08-30.at.3.08.33.PM.mov

Add CodeSandbox link to illustrate the issue (If applicable)

Describe specs for failing cases if this is an issue (If applicable)

Describe the changes proposed/implemented in this PR

Link Github issue if this PR solved an existing issue

Example usage (If applicable)

Screenshot (If applicable)

Please check which browsers were used for testing

  • Chrome
  • Chrome (Android)
  • Safari (OSX)
  • Safari (iOS)
  • Firefox
  • Firefox (Android)

@s-yadav
Copy link
Owner

s-yadav commented Sep 5, 2024

Thanks for the PR. Changes looks good. Merging.

@s-yadav s-yadav merged commit 69a5ed7 into s-yadav:master Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants