Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trans to RxJava2 #44

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

trans to RxJava2 #44

wants to merge 1 commit into from

Conversation

zzfmusic
Copy link

@zzfmusic zzfmusic commented Jun 7, 2019

No description provided.

DroidPulkit
DroidPulkit suggested changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@DroidPulkit DroidPulkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we can move the codebase to the new AndroidX namespace.

README.md Show resolved Hide resolved
app/build.gradle Show resolved Hide resolved
@zzfmusic
Copy link
Author

zzfmusic commented Jun 7, 2019

yes

@zzfmusic
Copy link
Author

zzfmusic commented Jun 7, 2019

yes,you merge,and rm what you want ,i only trans code to Rxjava2,because i project is Rxjava2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DroidPulkit DroidPulkit DroidPulkit requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zzfmusic @DroidPulkit @CaseStatiC