Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ModelConfiguration serialization #222

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

SimBe195
Copy link
Contributor

@SimBe195 SimBe195 commented Jun 3, 2024

This PR adds a new version of the build_config_constructor_serializers function. Compared to the previous one, now also Enum values as well as list, tuple and dict values with non-primitive elements inside are serialized. This is useful for example for the GenericFrontendV1 which use a sequence of FrontendLayerType enum values for the layer ordering. This wouldn't work with the original function but is possible with the v2 version.

Another change is that the de-duplication of the recognized imports now works properly and imports get sorted.

The changes are realized in a v2 function because they can affect the hash of the serializer objects and thus would break existing setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant