Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tedlium Hybrid Baseline #151

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Tedlium Hybrid Baseline #151

wants to merge 28 commits into from

Conversation

Atticus1806
Copy link
Contributor

No description provided.

@Atticus1806 Atticus1806 marked this pull request as ready for review August 29, 2023 14:39
@JackTemaki
Copy link
Contributor

@christophmluscher is it possible to get the modifications to the Systems in smaller PRs? This is sheer impossible to review.

@JackTemaki
Copy link
Contributor

After an offline discussion with @Atticus1806 , given that the setup changes are breaking existing setups and possibly need multiple weeks/months of review for a rather deprecated pipeline, I will do a local copy of setup within the tedlium 2 baseline folder. Then we can merge the setup now, and step-by-step update the setup code with smaller PRs.

This was referenced Sep 13, 2023
Closed
Closed
@Atticus1806 Atticus1806 mentioned this pull request Sep 13, 2023
Closed
@christophmluscher
Copy link
Contributor

wait for #182 #179

Marvin84
Marvin84 reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@Marvin84 Marvin84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

common/baselines/tedlium2/gmm/baseline_args.py Show resolved Hide resolved
common/baselines/tedlium2/gmm/baseline_args.py Outdated Show resolved Hide resolved
common/baselines/tedlium2/hybrid/baseline_config.py
from .nn_config.nn_args import get_nn_args


def run_gmm_system():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the FSA bug correction included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. Where / how would that be included? RASR version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it should be

@christophmluscher
Copy link
Contributor

PR #179 and #182 are merged here and into main. so this can proceed now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marvin84 Marvin84 Marvin84 left review comments

@christophmluscher christophmluscher Awaiting requested review from christophmluscher

@JackTemaki JackTemaki Awaiting requested review from JackTemaki

@michelwi michelwi Awaiting requested review from michelwi

@vieting vieting Awaiting requested review from vieting

Assignees

@christophmluscher christophmluscher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Atticus1806 @JackTemaki @christophmluscher @Marvin84 @michelwi