Add full_orth function

[Icemole]

Function to get the full orthographhy from the segment.

This function should be used from now on instead of accessing orth directly. We can also name the function orth() to minimize the impact of the change.

[Icemole]

Question: should we add this as a property of orth instead? But then we'd have to create a self._orth variable, which implies also doing some kind of setter:

@property
def orth(self):
    # Same as current full_orth()

@orth.setter
def orth(self, text):
    self._orth = text

But then this would be super misleading:

s = Segment()
s.left_context_orth = "Hello"
s.orth = "world"
print(s.orth)  # 'Hello world', instead of the potentially expected 'world'.

[albertz]

Question: should we add this as a property of orth instead?

No.

[michelwi]

Question: should we add this as a property of orth instead?

No.. as you already noticed this would be a terrible interface.

Also all Jobs that interact with the lib would need special logic to handle the optionality of the *_context_orth.