-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major Refactor #18
Major Refactor #18
Conversation
Additional objects implemented Standardized function naming Fixed missing error handling Support and enforce QB's rate limiting Bumped Go to 1.18 as 1.14 is EOL Ran `gofumpt -w` over the repo to cleanup code formatting
@rwestlund is there any chance of this getting reviewed? :) |
Hey, sorry for not looking at this sooner. It became one of those critical dependencies that gets ignored because it was working. Looks like there was a build failure: I've tagged current master as v1.0.0 and would be happy to merge this once that's resolved and tag it v2.0.0. |
Hey @rwestlund, no worries I know what that's like! I believe that error occured as the GH Action was using an older version of Go, where I've bumped this library to 1.20 (as older versions are EOL). Please re-run the build action, and it should work! |
Hey @rwestlund, any chance you've got some time to review this? :) |
Thanks for the follow up. I've merged and tagged v2.0.0! |
I believe this should resolve the issue mentioned here so that v2 is installable: rwestlund#18 (comment)
Commit Notes
Additional objects implemented
Standardized function naming
Fixed missing error handling
Support and enforce QB's rate limiting
Bumped Go to 1.18 as 1.14 is EOL
Ran
gofumpt -w
over the repo to cleanup code formattingDescription
Hey! Awesome library, the authorization flow was something I was struggling with myself, so this saved me a lot of time.
I've refactored the majority of the library to try and enforce consistency throughout. I've also implemented a few new entities. I realise this is a pretty significant refactor, and I'm sure you'll question or disagree with certain decisions made. But please take a look when you have the time to do so, and I'll be sure to either explain or resolve any issues you raise.
Thanks!