Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for sim output with multiple sims #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gidden
Copy link

@gidden gidden commented Aug 20, 2015

not perfect, but starts to address #5

before this patch:

$ cyan -db ~/work/publications/dre/scenarios/cyclus.sqlite sims
SimId                                Duration Handle      Decay  
fdf043b6-b0c9-4055-8773-6bb9cfaf0ace 600      dre_recycle manual 

after:

$ ./cyan -db ~/work/publications/dre/scenarios/cyclus.sqlite sims
SimId                                Duration Handle      Decay  
fdf043b6-b0c9-4055-8773-6bb9cfaf0ace 600      dre_recycle manual 
SimId                                Duration Handle   Decay  
bbda8c4f-8156-4ceb-9fd5-6fbfad05184c 600      dre_base manual

this uses the basic doCustom() plumbing thus repeats the headers. it could be cleaned up to not repeat headers and get better spacing. or a better sql command could be used to loop over all simids in doSims(). probably the second is a better choice, but my go + sql-foo is nonexistant + rusty.

@rwcarlsen
Copy link
Owner

I had just flubbed on the sql query - it shouldn't have been filtering
based on the first simid in the db like it does for other commands
[facepalm]. Fixed in 5c6700b. Thanks for
the issue report!

On Thu, Aug 20, 2015 at 2:09 PM, Matthew Gidden [email protected]
wrote:

not perfect, but starts to address #5
#5

before this patch:

$ cyan -db ~/work/publications/dre/scenarios/cyclus.sqlite sims
SimId Duration Handle Decay
fdf043b6-b0c9-4055-8773-6bb9cfaf0ace 600 dre_recycle manual

after:

$ ./cyan -db ~/work/publications/dre/scenarios/cyclus.sqlite sims
SimId Duration Handle Decay
fdf043b6-b0c9-4055-8773-6bb9cfaf0ace 600 dre_recycle manual
SimId Duration Handle Decay
bbda8c4f-8156-4ceb-9fd5-6fbfad05184c 600 dre_base manual

this uses the basic doCustom() plumbing thus repeats the headers. it
could be cleaned up to not repeat headers and get better spacing. or a
better sql command could be used to loop over all simids in doSims().
probably the second is a better choice, but my go + sql-foo is nonexistant

+ rusty.

You can view, comment on, or merge this pull request online at:

#6
Commit Summary

  • added support for sim output with multiple sims

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#6.

@gidden
Copy link
Author

gidden commented Aug 22, 2015

Gah, I should have been able to figure that out. sorry =(

On Sat, Aug 22, 2015 at 6:14 PM, Robert Carlsen [email protected]
wrote:

I had just flubbed on the sql query - it shouldn't have been filtering
based on the first simid in the db like it does for other commands
[facepalm]. Fixed in 5c6700b. Thanks for
the issue report!

On Thu, Aug 20, 2015 at 2:09 PM, Matthew Gidden [email protected]
wrote:

not perfect, but starts to address #5
#5

before this patch:

$ cyan -db ~/work/publications/dre/scenarios/cyclus.sqlite sims
SimId Duration Handle Decay
fdf043b6-b0c9-4055-8773-6bb9cfaf0ace 600 dre_recycle manual

after:

$ ./cyan -db ~/work/publications/dre/scenarios/cyclus.sqlite sims
SimId Duration Handle Decay
fdf043b6-b0c9-4055-8773-6bb9cfaf0ace 600 dre_recycle manual
SimId Duration Handle Decay
bbda8c4f-8156-4ceb-9fd5-6fbfad05184c 600 dre_base manual

this uses the basic doCustom() plumbing thus repeats the headers. it
could be cleaned up to not repeat headers and get better spacing. or a
better sql command could be used to loop over all simids in doSims().
probably the second is a better choice, but my go + sql-foo is
nonexistant

+ rusty.

You can view, comment on, or merge this pull request online at:

#6
Commit Summary

  • added support for sim output with multiple sims

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#6.


Reply to this email directly or view it on GitHub
#6 (comment).

Matthew Gidden, Ph.D.
Postdoctoral Associate, Nuclear Engineering
The University of Wisconsin -- Madison
Ph. 225.892.3192

@rwcarlsen rwcarlsen force-pushed the master branch 2 times, most recently from 9344575 to addbfce Compare December 17, 2015 17:10
@rwcarlsen rwcarlsen force-pushed the master branch 2 times, most recently from 29bf230 to 2bbb388 Compare May 6, 2016 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants