-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to pass in an ID and selectively clear tasks #16
base: master
Are you sure you want to change the base?
Conversation
I'm still wrapping my head around two things.
p.s. Travis is always a jerk to temporal. |
Yes
Let's see if that's something that comes up as a need. WDYT? |
Edited to clarify exportable.queue vs internal queue. So I solidified my understanding of exportable->queue->tasks, what events are bound to each and the lifespan of each... Oh and having exportable.queue and the internal queue really threw me. It all makes sense now. A user would want to be able to halt a task without (eventually) removing the exportable's busy and idle listeners when the internal queue empties. They may be enqueueing tasks later on in their app and they will expect those listeners to still exist. Removing listeners (eventually) when clearing by ID is not a good thing. If we are not removing listeners then the behavior more closely matches the existing queue.stop() behavior so we should change it to queue.stop(id). I'm sorry I put us on the wrong path initially. |
Crap, my whole understanding is flawed. Finally recognizing the difference between the internal queue and instances of Queue changes everything. I think I can do what I wanted to do w/ Temporal as is. Insert long string of curse words here. |
You can close this. It is not necessary. |
Just a reminder to close this. I still have this on another branch, but I really don't think it's necessary and we should close it. |
cc @dtex